briansmith / ring

Safe, fast, small crypto using Rust
Other
3.74k stars 704 forks source link

CI: Run `cargo package` for all supported targets before publishing #1879

Open briansmith opened 10 months ago

briansmith commented 10 months ago

cargo package by default builds the package for the default target, and this is what the current package job in CI does. However, this doesn't work well for us as we have many target-specific files, especially target-specific C and assembly/PerlAsm files.

Instead, we should recognize that a commit that is supposed to be the last one prior to a release, and run cargo package for every target for these commits, in addition to the normal test matrix, to ensure that the crate builds for all supported targets before publishing.