Open briansmith opened 8 months ago
The change that implements this should be done in a single PR. I will use diff
against the latest commit of the aes
crate sources on GitHub to verify that the first commit is exactly identical to what's in the upstream source. Then I will review each commit in the PR as though it were its own PR. So basically the submitter needs to be prepared to do a lot of rebasing through the review process if there are many rounds of review.
The code is at https://github.com/RustCrypto/block-ciphers/tree/master/aes/src/soft.
src/rust_crypto/aes/soft/
in the ring sources.hazmat
and other code that will never be needed. Retain the decryption code; even though it will be dead code; the future AES-CBC code will use it.Block
type in a way that does not use thecipher
crate.FixsliceBlocks
andBatchBlocks
with types that do not use thecipher
crate.ring::aead::aes
to use the newly-vendored code instead of aes_nohw.c. Remove aes_nohw.c, aes/internal.h, and all references to the files from build.rs and Cargo.toml.