Open tisonkun opened 8 months ago
Attention: Patch coverage is 88.88889%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 96.30%. Comparing base (
9cb93e0
) to head (407599a
). Report is 31 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
crypto/curve25519/curve25519.c | 88.88% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for your review @briansmith!
Do you think it's better to exclude changes around src/constant_time.rs
in this PR and move forward, or we can wait for https://github.com/briansmith/ring/pull/1899 merged?
Yes, I think we should limit this to the curve25519.c change and mem.h deletion.
Updated. PTAL @briansmith.
@briansmith ping as a reminder :D
@briansmith ping as a reminder :D
@briansmith I suppose the codecov regression is false positive..
@briansmith is there other blocker to this PR?
This refers to #1827.
An intuitive solution according to @briansmith's comment. But I know little about crypto so perhaps some invariants are broken.