Closed DavidHorton5339 closed 4 months ago
Hmm...why would our CI jobs pass if this happens?
They are warnings. Does your CI treats warnings as errors (mk/cargo.sh test run from command line does not)?
Warnings confirmed in example https://github.com/briansmith/ring/actions/runs/7492345579/job/20400988301
I do see the warnings but they do not cause the build to break.
Sorry, should have made it clear - it's -D warnings
in our application build that's causing builds to fail. We don't really expect warnings from 3rd party crates (or our own code), and ring
did not formerly issue any.
Is there a way to get the #[allow(deprecated])
to work? If not, I will accept a PR that replaces the #[deprecated]
with a comment and that removes the useless #[allow(deprecated])
.
I think the code as it is is trying to apply #[allow(deprecated)]
to the function after macro expansion, rather than to the macro invocation itself. I don't know of a way of applying an attribute to a macro invocation - I doubt this is possible. The only way I could get it to work is by having #![allow(deprecated)]
at the file level in montgomery.rs
(and removing the useless #[allow(deprecated]
on the macro invocation). Would that work for you?
I think we're better off just replacing the #[deprecated(...)]
on the definition with a comment, and then removing the #[allow(deprecated)]
. I still want to get other deprecation warnings, if any, in montgomery.rs.
Yes, that would be better than using the deprecation as a TODO marker, then masking it.
I'm going to close this. It is annoying that we have these warnings but we don't need to have an issue to track the annoyance.
Recent changes have marked
prefixed_export!
macro as deprecated, and simultaneously tried to ignore the deprecated macro option. Unfortunately this still throws up a warning which causes builds to fail. The macro is only defined/used for architectures other thanaarch64
,arm
,x86
andx86_64
, so only those architectures are affected. Example targets exhibiting the problem arepowerpc-unknown-linux-gnu
,mipsel-unknown-linux-gnu
warning: use of deprecated macroprefixed_export
:#[export_name]
creates problems and we will stop doing it.