search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.69k stars 697 forks source link

clippy: fix warning on aarch64 #1900

Closed vkrasnov closed 7 months ago

vkrasnov commented 8 months ago

Fix warning: unneededreturnstatement on aarch65

briansmith commented 8 months ago

The code is written this way so that if we change the #[cfg(...)] logic, it will still do the right thing. Accordingly, normally we'd address this instead by putting a #[allow(needless_return)] on the function. In this case, it seems like we need to deal with some situations where we shouldn't be using NEON even on AAarch64, so I've submitted #1901 as an alternative solution that addresses this while stepping in that direction.

briansmith commented 7 months ago

Closing since this was subsumed by PR #1901.