search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.69k stars 697 forks source link

aes-gcm: Don't assume NEON is available on AArch64. #1901

Closed briansmith closed 7 months ago

briansmith commented 8 months ago

Some of the assembly probably assumes NEON is available on Aarch64, so don't remove the assertion in the feature detection logic. But move closer to supporting NEON-less Aarch64 configurations, e.g. within an OS kernel or when NEON is disabled for testing purposes, or when we have a target that for whatever reason doesn't statically enable NEON for AAarch64 and also doesn't support dynamic feature detection.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c72a5aa) 96.02% compared to head (87fa01f) 96.02%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1901 +/- ## ========================================== - Coverage 96.02% 96.02% -0.01% ========================================== Files 136 136 Lines 20776 20758 -18 Branches 226 226 ========================================== - Hits 19950 19932 -18 Misses 792 792 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

briansmith commented 8 months ago

@vkrasnov Could you please take a look at this? I think this will subsume #1900.