briansmith / ring

Safe, fast, small crypto using Rust
Other
3.69k stars 697 forks source link

CI: Use llvm-tools-preview toolchain instead of external llvm-tools toolchain #1903

Open briansmith opened 8 months ago

briansmith commented 8 months ago

Each checklist item above should be done as a separate PR, ideally.

briansmith commented 8 months ago

PR #1908 attempts to resolve the mk/check-symbol-prefixes.sh parts.

briansmith commented 6 months ago
  • mk/{install-build-tools.sh, should not do install_packages llvm-$llvm_version

It still needs to, but only when we are in $use_clang mode.

Instead we should install the tools using rustup +$toolchain toolchain component add llvm-tools-preview before the coverage runs. This would require us to parse "+$toolchain" out of the command line, much like we parse "--target=$target". We'd need to update ci.yml accordingly to pass +${{ matrix.rust_channel }} on the command line.

Done in PR #1980.

In mk/check-symbol-prefixes.sh, we should similarly switch to using the llvm-tools-preview llvm-nm, and change ci.yml accordingly. We should change the conditional logic in ci.yml so that mk/check-symbol-prefixes.sh is run for apple targets, where it is currently being skipped.

Done in PR #1908.