search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.69k stars 697 forks source link

CI: Use llvm-tools-preview instead of external llvm-tools for symbol prefix testing #1908

Closed briansmith closed 8 months ago

briansmith commented 8 months ago

See individual commit messages for details. This makes the script portable to all hosts and allows us to expand the symbol prefix checking to all tested targets. It also allows us to avoid incompatibilities between Apple nm and the toolchain's output.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3e50503) 96.02% compared to head (3cb66f5) 96.02%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1908 +/- ## ======================================= Coverage 96.02% 96.02% ======================================= Files 136 136 Lines 20776 20776 Branches 226 226 ======================================= Hits 19950 19950 Misses 792 792 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

briansmith commented 8 months ago

https://github.com/briansmith/ring/actions/runs/7515538763/job/20459551889 is a run that intentionally breaks symbol prefixing, to test this.

briansmith commented 8 months ago

It looks like the Windows builds are using PowerShell to run the shell script, and "passing" even though they aren't doing any work. :( I'll need to update this to force the use of mingw bash for windows.

briansmith commented 8 months ago

It looks like the Windows builds are using PowerShell to run the shell script, and "passing" even though they aren't doing any work. :( I'll need to update this to force the use of mingw bash for windows.

Well, after that, it seems more work is needed for Windows. Will split the Windows work off into a separate issue/PR.

briansmith commented 8 months ago

https://github.com/briansmith/ring/actions/runs/7516068245 is the new test run to make sure CI fails when an unprefixed symbol exists.

briansmith commented 8 months ago

https://github.com/briansmith/ring/actions/runs/7516194196 was the final test run that shows that the builds break when there is an unprefixed symbol.