Closed briansmith closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
73fb637
) 91.58% compared to head (ec16ff2
) 96.02%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@pixlwave @lcruz99 @BlackHoleFox PTAL at this, since you've been interested in this topic previously.
@BlackHoleFox Thanks for taking a look. I updated the PR to address the build.rs nit you mentioned, and to clarify the issue with x25519_NEON. PTAL.
I'm going to close this without merging it. I don't like the denylist-like approach. I think we only need to support x25519_neon for, at most, Linux and Android, so we should switch to an allowlist-based approach that lists them specifically. Further, we should change build.rs so that x25519_neon is not compiled at all on non-Linux/Android targets.
Seems reasonable, thanks for the backnforth.
Expand the conditions in which the x25519_neon function will be avoided. This is a temporary measure until we can properly condition it on the target ABI.