search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.68k stars 693 forks source link

build.rs: Remove some previously-added C compiler warnings. #1952

Closed briansmith closed 6 months ago

briansmith commented 6 months ago

Remove "-Winline" in particular because it has caused problems for multiple people trying to port ring to new targets.

Remove '-Wextra", trusting the C compiler writers' judgement about what should be in "-Wall."

Remove some others since they're more-or-less no longer relevant as we decrease the C code in ring.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (68bf136) 96.23% compared to head (81fed3c) 96.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1952 +/- ## ======================================= Coverage 96.23% 96.23% ======================================= Files 135 135 Lines 20656 20656 Branches 226 226 ======================================= Hits 19879 19879 Misses 743 743 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.