search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.77k stars 708 forks source link

aarch64-apple-*: Improve `unsafe` usage. #1986

Closed briansmith closed 8 months ago

briansmith commented 8 months ago

Make detect_feature a safe function by haivng it do a (clearly superfluous) check on the well-formedness of its input.

briansmith commented 8 months ago

FYI @BusyJay. In the midst of getting it to work with MSRV 1.61, I got the priorities mixed up regarding unsafe. This should work exactly the same

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.30%. Comparing base (5fb6541) to head (51f1456).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1986 +/- ## ========================================== + Coverage 96.28% 96.30% +0.02% ========================================== Files 137 137 Lines 20723 20728 +5 Branches 226 226 ========================================== + Hits 19953 19962 +9 + Misses 735 732 -3 + Partials 35 34 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.