Open Raghav-Bell opened 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.80%. Comparing base (
ee1e217
) to head (6d493b1
). Report is 64 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
From the CI run:
qemu: uncaught target signal 11 (Segmentation fault) - core dumped /home/runner/work/ring/ring/mk/runner: line 21: 6499 Segmentation fault (core dumped) $* error: test failed, to rerun pass `-p ring --lib`
This kind of crash seems to happen when the clang version doesn't match the LLVM version that Rust uses. It seems like we upgraded clang in CI to what Nightly Rust uses. In order to move forward with this change, we may either need to downgrade to the earlier version of clang that matches stable Rust's LLVM version, or wait until the next stable Rust is released.
You might try using channel beta
to see if the beta channel is using the new version of LLVM to get an idea of how long we'd need to wait.
@briansmith You are right
stable
needs LLVM $\geq
$ 16
beta
& nightly
are compatible with LLVM ==18.
I will push it to beta
for now, later we can move it to stable. Thanks
@Raghav-Bell Do you want to try again now?
OK, this seems to be working now on stable. Could you please do the following?:
CI: Use stable Rust toolchain for code coverage.
Use the stable Rust toolchain for code coverage in CI. This should make coverage measurements more stable day-to-day and also make it easier for people to replicate coverage measurements on locally.
Since PR #2056 was merged, we'll need to wait for Rust 1.80 (IIUC) to become stable, or else add a wokaround that forces the use of nightly for the armv7 target.
It fixes #1902