search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.65k stars 684 forks source link

digest internals: Refactor to clarify safety #1992

Closed briansmith closed 4 months ago

briansmith commented 4 months ago

Refactor ring::digest to minimize the use of unsafe.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.25352% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 96.28%. Comparing base (da16607) to head (e7b9501).

Files Patch % Lines
src/digest/dynstate.rs 79.62% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1992 +/- ## ========================================== - Coverage 96.31% 96.28% -0.04% ========================================== Files 137 139 +2 Lines 20723 20803 +80 Branches 226 226 ========================================== + Hits 19960 20030 +70 - Misses 728 739 +11 + Partials 35 34 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

briansmith commented 4 months ago

The codecov.io checks are false alarms. Two of them are in const fn that are only to be used at compile time, and the others are in unreachable!() calls.