search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.72k stars 704 forks source link

Add __XTENSA__ to target.h #2010

Closed coder0xff closed 4 months ago

coder0xff commented 6 months ago

Hi. Would you trigger the workflow please?

coder0xff commented 5 months ago

@briansmith Is it safe to assume that the ci / deny failure is unrelated?

briansmith commented 4 months ago

Please:

  1. Make a mk/install-build-tools-unsupported.sh that is in the same form of mk/install-build-tools.sh, which adds support for installing the xtensa toolchain on an Ubuntu system, starting from the state where qemu-xtensa is not installed.
  2. Make a mk/cargo-unsupported.sh that mirrors mk/cargo.sh which uses the xtensa toolchain to run cargo commands in qemu-xtensa.
  3. Update .github/workflows/ci.yml to add the xtensa target to the test matrix.
briansmith commented 4 months ago

Instead of continuing to grow this allowlist, I'd rather eliminate it. Please help with implementing the strategy in https://github.com/briansmith/ring/pull/2042#issuecomment-2120898907 if you can.