briansmith / ring

Safe, fast, small crypto using Rust
Other
3.65k stars 684 forks source link

AES-GCM: Clarify GHASH assembly safety. #2017

Closed briansmith closed 3 months ago

briansmith commented 3 months ago

Create polyfills for recently-added slice methods and use them to clarify the safety of gcm::Context::update_blocks(). Encapsulate the declarations in a macro and add SAFETY to document the interface.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 96.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 96.53%. Comparing base (68e69fb) to head (4ad98e9).

Files Patch % Lines
src/polyfill/slice.rs 91.66% 2 Missing :warning:
src/aead/gcm.rs 97.67% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2017 +/- ## ========================================== + Coverage 96.29% 96.53% +0.23% ========================================== Files 140 138 -2 Lines 20820 17004 -3816 Branches 226 226 ========================================== - Hits 20049 16415 -3634 + Misses 736 556 -180 + Partials 35 33 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.