search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.72k stars 704 forks source link

AES-GCM internals: Use consistent definitions for `Counter`. #2020

Closed briansmith closed 6 months ago

briansmith commented 6 months ago

Use the same type definition for counters as BoringSSL and aes_nohw_ctr32_encrypt_blocks. This should be a no-op for correctness as the representation is effectively the same, except now with looser (u8 vs u32) alignment. This is much clearer though, and removing the type punning paves the way for aes_nohw.c to be replaced with Rust code.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.19%. Comparing base (0093085) to head (8677f94). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2020 +/- ## ========================================== - Coverage 96.30% 96.19% -0.12% ========================================== Files 140 140 Lines 20876 20889 +13 Branches 226 226 ========================================== - Hits 20105 20094 -11 - Misses 736 760 +24 Partials 35 35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.