search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.72k stars 704 forks source link

AES-GCM: Align the types in AArch64 AES-GCM assembly with BoringSSL. #2021

Closed briansmith closed 5 months ago

briansmith commented 6 months ago

Make it easier to compare ring's declarations with BoringSSL's for these functions by using u64 instead of usize for the in_bits argument to aesgcm{dec,enc}_kernel. Use NonZeroU64 to indicate that the assembly functions do not work with zero-length inputs.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.18%. Comparing base (252743a) to head (087e941).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2021 +/- ## ======================================= Coverage 96.18% 96.18% ======================================= Files 140 140 Lines 20888 20902 +14 Branches 226 226 ======================================= + Hits 20091 20105 +14 Misses 763 763 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.