search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.76k stars 708 forks source link

CPU Linux: Stop detecting non-NEON features on 32-bit ARM. #2051

Closed briansmith closed 6 months ago

briansmith commented 6 months ago

Split the 32-bit ARM feature deteection from AArch64 feature detection.

Simpliy the 32-bit ARM feature detection to only look for NEON, so that hardware implementations are never used on 32-bit ARM. In particular, this drops the usage of hardware SHA implementations on 32-bit ARM.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.27%. Comparing base (c5914cd) to head (fab5046).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2051 +/- ## ========================================== - Coverage 96.28% 96.27% -0.01% ========================================== Files 143 143 Lines 20462 20430 -32 Branches 226 226 ========================================== - Hits 19701 19669 -32 Misses 727 727 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.