Closed briansmith closed 6 months ago
Attention: Patch coverage is 85.71429%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 96.27%. Comparing base (
c5914cd
) to head (2a38158
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/aead/aes.rs | 85.71% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It turns out BSAES isn't the only one that required a non-empty in/out; at least the x86-64 implementation of
aes_hw_ctr32_encrypt_blocks
requires a non-empty in/out as well. Just assume all of them require it.As the code currently exists, this is a no-op because
ctr32_encrypt_within
is never called with an empty in/out, but this would prevent memory safety issues if/when that changes.