search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.76k stars 708 forks source link

x86: Remove 32-bit SIMD AES implementation. #2060

Closed briansmith closed 6 months ago

briansmith commented 6 months ago

The C code is never built with OPENSSL_SSE2 so this has been dead code. Don't put any effort into getting it to work as there seems to be very little interest in 32-bit x86 performance.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.66%. Comparing base (0426979) to head (af9a0ba).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2060 +/- ## ========================================== - Coverage 96.85% 92.66% -4.19% ========================================== Files 144 110 -34 Lines 20708 10639 -10069 Branches 244 0 -244 ========================================== - Hits 20056 9859 -10197 - Misses 618 780 +162 + Partials 34 0 -34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

briansmith commented 6 months ago

Closing in favor of doing the opposite in PR #2062.