briansmith / ring

Safe, fast, small crypto using Rust
Other
3.64k stars 682 forks source link

aes: Split FFI helpers into their own submodule. #2102

Closed briansmith closed 2 weeks ago

briansmith commented 2 weeks ago

Make it clearer which types are used in the FFI and start separating the (unsafe) code for dealing with the C/assembly implementations from the (mostly safe) rest of the code.

git difftool HEAD^1:src/aead/aes.rs src/aead/aes/ffi.rs.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 97.93814% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.25%. Comparing base (e3593b4) to head (a6c2366). Report is 2 commits behind head on main.

Files Patch % Lines
src/aead/aes.rs 90.90% 1 Missing :warning:
src/aead/aes/ffi.rs 98.83% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2102 +/- ## ========================================== + Coverage 97.24% 97.25% +0.01% ========================================== Files 143 144 +1 Lines 20144 20148 +4 Branches 228 228 ========================================== + Hits 19589 19595 +6 - Misses 527 528 +1 + Partials 28 25 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.