search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.77k stars 708 forks source link

gcm: Split FFI helpers into a separate submodule. #2103

Closed briansmith closed 5 months ago

briansmith commented 5 months ago

Make it clearer which types are used in the FFI and start separating the (unsafe) code that's used only for the FFI from the (safe) code used in the Rust implementation.

git difftool HEAD^1:src/aead/gcm.rs src/aead/gcm/ffi.rs

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 98.85057% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.25%. Comparing base (e3593b4) to head (972e236). Report is 2 commits behind head on main.

Files Patch % Lines
src/aead/gcm/ffi.rs 98.38% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2103 +/- ## ========================================== + Coverage 97.24% 97.25% +0.01% ========================================== Files 143 144 +1 Lines 20144 20135 -9 Branches 228 228 ========================================== - Hits 19589 19583 -6 Misses 527 527 + Partials 28 25 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.