search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.77k stars 708 forks source link

Add *-apple-{visionos,watchos} support; CI: build tvOS,visionOS,watchOS. #2112

Closed briansmith closed 5 months ago

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.08%. Comparing base (481462e) to head (1b8f998).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2112 +/- ## ======================================= Coverage 97.07% 97.08% ======================================= Files 144 144 Lines 20124 20124 Branches 456 456 ======================================= + Hits 19535 19537 +2 Misses 492 492 + Partials 97 95 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

briansmith commented 5 months ago

Note that this might cause some large tables to be added to the build for P-256 and X25519 that weren't included before, which could significantly bloat the size of the app. This might be especially concerning for watchOS applications. We may want to merge BoringSSL's https://boringssl.googlesource.com/boringssl/+/20c9406971b39d214d4d6997f3a6e3ec772c440a to address this.

eugenehp commented 5 months ago

Looks good, just be careful with the target_vendor part https://github.com/rust-lang/rust/issues/100343