search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.64k stars 682 forks source link

arm: Switch from denylisting Apple targets to allowlisting Android/Linux. #2116

Closed briansmith closed 1 week ago

briansmith commented 1 week ago

The allowlist approach is safer.

briansmith commented 1 week ago

@eugenehp Thanks for your comment in the other PR about the target_vendor usage. It caused me to reconsider some of the use of it, and this PR removes those uses. PTAL.

I think the rest of the target_vendor = "apple" usage is benign if redundant. I guess if/when it causes trouble we can reconsider it.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.07%. Comparing base (9593d9b) to head (88a3445).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2116 +/- ## ======================================= Coverage 97.07% 97.07% ======================================= Files 144 144 Lines 20124 20124 Branches 456 456 ======================================= + Hits 19535 19536 +1 Misses 492 492 + Partials 97 96 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.