search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.64k stars 682 forks source link

aes_gcm: Prefer integrated implementations, avoid inlining fallbacks. #2119

Closed briansmith closed 1 week ago

briansmith commented 1 week ago

The #[inline(always)] on open_strided was just a mistake.

But, even correcting that, the compiler won't structure open() and seal() in the expected way. With these changes, the integrated implementations will get inlined (as far as possible) and the compiler will be biased towards assuming they will be used.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.12%. Comparing base (525047a) to head (1cad1ee).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2119 +/- ## ======================================= Coverage 97.12% 97.12% ======================================= Files 151 151 Lines 20101 20101 Branches 447 447 ======================================= Hits 19524 19524 Misses 482 482 Partials 95 95 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.