search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.76k stars 708 forks source link

aes: Clarify counter overflow checking. #2120

Open briansmith opened 5 months ago

briansmith commented 5 months ago

Create a more robust internal API for counter/nonce/IV management that makes the usage within AES-GCM more clearly correct. The new design is easier to test.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 93.73737% with 31 lines in your changes missing coverage. Please review.

Project coverage is 97.04%. Comparing base (fd06b00) to head (812ebfc).

Files Patch % Lines
src/aead/aes_gcm.rs 81.91% 17 Missing :warning:
src/aead/gcm.rs 41.66% 7 Missing :warning:
src/aead/aes/counter.rs 99.23% 1 Missing and 1 partial :warning:
src/aead/aes/ffi.rs 81.81% 1 Missing and 1 partial :warning:
src/aead/aes/vp.rs 96.87% 2 Missing :warning:
src/aead/aes.rs 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2120 +/- ## ========================================== - Coverage 97.12% 97.04% -0.09% ========================================== Files 151 152 +1 Lines 20101 20475 +374 Branches 447 454 +7 ========================================== + Hits 19524 19870 +346 - Misses 482 508 +26 - Partials 95 97 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.