search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.76k stars 708 forks source link

Allow loading ECDSA private key from PKCS8 file missing public key #2134

Closed aj-bagwell closed 1 month ago

aj-bagwell commented 3 months ago

PKCS8 encoded pem files have an option to have the public key in the same file as the private key.

Not all pem files will have it, and the public key can be derived from the private key anyway.

Fixes #2133

I agree to license my contributions to each file under the terms given at the top of each file I changed.

briansmith commented 1 month ago

Thanks for the PR. I'm going to close the PR for the reasons I mentioned in https://github.com/briansmith/ring/issues/2133#issuecomment-2380414477, but I will be happy to review a new PR that meets the design requirements.