search

briansmith / webpki

WebPKI X.509 Certificate Validation in Rust
https://briansmith.org/rustdoc/webpki/
Other
464 stars 166 forks source link

Optional serde support for DnsName/DnsNameRef #238

Closed clarfonthey closed 5 months ago

clarfonthey commented 3 years ago

I would add implement Serialize/Display for DnsNameRef but I figured there was a good reason to not store it as &str, and didn't want to bother with refactoring that without talking to anyone.

This adds serde support for both types under an optional feature. It also implements Display for DnsName since I figured it'd be reasonable to have.

clarfonthey commented 7 months ago

cc @briansmith as I'm going through old PRs: assuming I resolve the merge conflict, would you still be interested in merging this, or should I assume that inaction here means it's not desired? I don't mind either way, just want to check since this PR is 3 years old and I wouldn't mind rebasing it if you do think it's useful.

briansmith commented 5 months ago

I don't think adding Serde support makes sense for this project. I think there are ways of doing this without webpki having to provide the functionality itself. Sorry about the radio silence.