briansmith / webpki

WebPKI X.509 Certificate Validation in Rust
https://briansmith.org/rustdoc/webpki/
Other
464 stars 165 forks source link

Wrong license identification on crates.io breaks guix importer #246

Open Kreyren opened 3 years ago

Kreyren commented 3 years ago

Guix importer generates an import as:

kreyren@leonid ~$ guix import crate webpki
following redirection to `https://static.crates.io/crates/webpki/webpki-0.22.0.crate'...
(define-public rust-webpki-0.22
  (package
    (name "rust-webpki")
    (version "0.22.0")
    (source
      (origin
        (method url-fetch)
        (uri (crate-uri "webpki" version))
        (file-name (string-append name "-" version ".tar.gz"))
        (sha256
          (base32 "1gd1gxip5kgdwmrvhj5gjxij2mgg2mavq1ych4q1h272ja0xg5gh"))))
    (build-system cargo-build-system)
    (arguments
      `(#:cargo-inputs
        (("rust-ring" ,rust-ring-0.16) ("rust-untrusted" ,rust-untrusted-0.7))
        #:cargo-development-inputs
        (("rust-base64" ,rust-base64-0.9))))
    (home-page "https://github.com/briansmith/webpki")
    (synopsis "Web PKI X.509 Certificate Verification.")
    (description "Web PKI X.509 Certificate Verification.")
    (license unknown-license!)))

Note the (license unknown-license!) which breaks the build and needs to be manually fixed on (license (list lisense:isc license:bsd-3)

Please fix the license metadata on crates.io to not be non-standard when the project is isc.

briansmith commented 3 years ago

Some of the files in the crate are not ISC licensed. In particular some of the test files. Unfortunately, Cargo doesn't seem to have a way of distinguishing the license of the test stuff from the license of the library.

briansmith commented 2 years ago

Note the (license unknown-license!) which breaks the build and needs to be manually fixed on (license (list lisense:isc license:bsd-3)

I overlooked this part of the suggestion. This seems like a fine change to make to me.

Kreyren commented 2 years ago

Sorry if i made that unclear, basically the suggestion is to use recognizable license on crates.io for automation purposes.