search

briansmith / webpki

WebPKI X.509 Certificate Validation in Rust
https://briansmith.org/rustdoc/webpki/
Other
464 stars 166 forks source link

Tidy up budget enforcement #279

Closed briansmith closed 1 year ago

briansmith commented 1 year ago

These are non-functional changes designed to clarify how the budget is encapsulated, along with some other tidying that I noticed was appropriate during the review of PR #277.

It is best to review this commit-by-commit.

briansmith commented 1 year ago

@cpu PTAL. Thanks!

codecov[bot] commented 1 year ago

Codecov Report

Merging #279 (895e2cb) into main (93aca11) will increase coverage by 0.07%. The diff coverage is 86.00%.

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   51.81%   51.88%   +0.07%     
==========================================
  Files          19       20       +1     
  Lines        4030     4036       +6     
==========================================
+ Hits         2088     2094       +6     
  Misses       1942     1942
Files Coverage Δ
src/budget.rs 100.00% <100.00%> (ø)
src/lib.rs 27.49% <ø> (ø)
src/verify_cert.rs 97.15% <ø> (-0.30%) :arrow_down:
src/error.rs 11.94% <66.66%> (+5.81%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more