search

brianstrauch / spotify-cli

Spotify for the terminal
Apache License 2.0
317 stars 16 forks source link

Add 'play --playlist' support. Issue #27 #41

Closed Threpio closed 3 years ago

Threpio commented 3 years ago

Fixes issue #27

Upgraded root spotify module from v0.5.0 => v0.6.0. Added --playlist flag to the play function that takes a playlist name and plays it.

Tests have been updated to reflect upgrade from spotify v0.5.0 -> v0.6.0 New tests required for additional features.

Threpio commented 3 years ago

@brianstrauch - PR for commands that would show how we can use the Spotify library. I will split the commands up to do searchPlaylists, searchAlbums and searchTracks

The tests pass but I am not sure they are done correctly

brianstrauch commented 3 years ago

Hey @Threpio, how's this coming along?

Threpio commented 3 years ago

Was away for the weekend - apologies.

Will have another update by this evening (CET)

Threpio commented 3 years ago

I won't be able to complete this for a week or so because of prior commitments - If you want to run with it then fire away!

Threpio commented 3 years ago

Done a couple of tests locally and it seems that all the new functionality is done correctly - Still intermittently getting the previous song shown when selecting a playlist...

EDIT: I would like for this to be a squash commit considering I mucked the git up a whole load.

brianstrauch commented 3 years ago

@Threpio Thanks, I'll take a look later today! ... and no worries, squash is the default for this repo :smile: