briantanner / eris-lavalink

MIT License
32 stars 15 forks source link

Voice connection timeout #4

Closed itsjakeb closed 6 years ago

itsjakeb commented 6 years ago
Error: Voice connection timeout
     at Timeout.pendingGuilds.(anonymous function).timeout.setTimeout [as _onTimeout] (/home/jake/discord/Adonis/node_modules/eris-lavalink/src/PlayerManager.js:323:25)
     at ontimeout (timers.js:469:11)
     at tryOnTimeout (timers.js:304:5)
     at Timer.listOnTimeout (timers.js:264:5)
briantanner commented 6 years ago

Could you provide any more info on it?

itsjakeb commented 6 years ago

Not much info to be provided. Happens quite often and I know other large bots that have this problem such as Pancake. Really not sure what causes it.

minemidnight commented 6 years ago

I get this error a bunch too. Used to happen with Eris, might want to ask abal on how he fixed it.

minemidnight commented 6 years ago

Any updates on this? It’s pretty bad for my users.

briantanner commented 6 years ago

Have any logs or debug that might help pinpoint the cause?

minemidnight commented 6 years ago

Nope. All I know is Eris used to have the same issue.

itslukej commented 6 years ago

Getting this too, however I've noticed that it happens more after the shard has lost connection with one of the voice nodes. https://sentry.davinci.sh/share/issue/332e333535/ image

itsjakeb commented 6 years ago

It's happening a lot more now than it ever has to me. Got to the point where it won't play.

briantanner commented 6 years ago

Any help would be appreciated. I haven't found anything in the client that could be causing it.

It is fixable by restarting the affected Lavalink node, it seems to get in a connect loop which is what I find causes it often times.

itsjakeb commented 6 years ago

Alright, its just constant. image

briantanner commented 6 years ago

Yeah, that doesn't help much.. The best that I've been able to figure out so far is that there's either something not implemented correctly in the client, or have been told it could be a JDA-Audio issue. However, I've looked through the client up and down for weeks looking for the cause and can't see anything glaring.

itslukej commented 6 years ago

I too have looked through eris-lavalink and I've seen nothing that could lead to this issue, given that JDA-Audio is experimental, It's probably coming from the lavalink server itself. I could ask someone using the JDA lavalink client to see if they have also experienced it

p4rkrs commented 6 years ago

I have a lot of that too. The people need to kick the bot, and wait like 5 minutes & thats will work

itslukej commented 6 years ago

We are now having cases where the bot will give a Voice connection timeout when it shows as not in the voice channel (compared to the previous times where the bot would show as in the voice channel), the only solution we have found so far to this is restarting the whole eris client (which is 5 shards, ~4.5k guilds for us, quite annoying 😕)

itslukej commented 6 years ago

Very sure this issue is on the lavalink server side. A 'fix' we have found for our users is to have them connect to a different lavalink server than the one that they are getting vc timeouts on image

freyacodes commented 6 years ago

Grepping the affected guild's id in the affected LL server's debug.log might give some clues

itsjakeb commented 6 years ago

I no longer get this issue but people still say they get it with other bots so I'll keep this issue open.

p4rkrs commented 6 years ago

@DoctorDarkMagic How?

itslukej commented 6 years ago

@itskiru #11

briantanner commented 6 years ago

Closing due to age, deprecation, and new bug fixes in the v1 branch

Bacon1661 commented 6 years ago

Still getting this issue.

itslukej commented 6 years ago

@Bacon1153 Have you updated eris-lavalink and lavalink server to v2?

Bacon1661 commented 6 years ago

@itslukej Yes, I've gotten this both on v1 and v2.

briantanner commented 6 years ago

This happens afaik, have always had this issue when dealing with music, if you can get more info on what's causing it and/or identify a bug in eris-lavalink, feel free to open a new issue.

Some possible causes: Permissions - View Channel, Connect, Use Voice Activity Voice Server/Region - Not sure how common, but happens on occasion that the voice server is to blame, changing region gets you on a new server.

Bacon1661 commented 6 years ago

It's strange, because some people don't have this issue at all and some people (like me) always get the error. I'll look into it.

Bacon1661 commented 6 years ago

I've been talking to some people and someone said that voiceServerUpdate is never getting called, causing the timeout to never be resolved. Very interesting.

briantanner commented 6 years ago

That would be because your bot never joins the channel, therefore never gets a voice server update, and times out... I would check the things I mentioned above, namely that the permissions are correct when it happens.

PassTheMayo commented 6 years ago

I've been getting the same issue, but it's seemed to go away after I messed with the code. It hasn't been happening today.

briantanner commented 6 years ago

@PassTheMayo "after I messed with the code" would be nice to know what this means if it's a bug in eris-lavalink

PassTheMayo commented 6 years ago

@briantanner I'm not sure what I did, because I changed a lot. I can't explain what I did, but it just doesn't do that now.

p4rkrs commented 6 years ago

Just use 0.1.2 with V1 of lavalink and everything is okay.

Bacon1661 commented 6 years ago

Why would you use v1?

briantanner commented 6 years ago

I would recommend people update to Lavalink v2 and eris-lavalink ^1.0.x

briantanner commented 6 years ago

I'm locking this issue, if anyone can identify a bug in eris-lavalink with a way to reproduce, please submit a new issue. Otherwise, refer to my previous comments, and make an effort to correct the issue on your end first. If that doesn't work, please provide some debugging information or even submit a pull request if you think you can contribute anything.