briantist / galactory

An Ansible Galaxy proxy for Artifactory
GNU General Public License v3.0
33 stars 7 forks source link

internals: "fast detection" for collection iteration doesn't work for non-stable versions #100

Closed briantist closed 11 months ago

briantist commented 11 months ago

https://github.com/briantist/galactory/blob/d1af36039326759d067b5e37f36bfd9eb7ecab66/galactory/utilities.py#L94

Pretty minor, but the fast detection will never work for a version that contains a hyphen like 1.2.3-alpha because the split will have more than 3 results.

This should be fixable by setting the second argument of split to 3.

This "failure" really just means falling back to "slow" detection that requires some additional requests.