briantist / galactory

An Ansible Galaxy proxy for Artifactory
GNU General Public License v3.0
33 stars 7 forks source link

Unit tests for Python >= 3.10 don't actually test much of anything #90

Open briantist opened 11 months ago

briantist commented 11 months ago

In #35 I got the tests working for Python 3.10 and 3.11.

This introduced some branching code in the definition of a MockArtifactoryPath class due to changes in pathlib (the underlying base class): https://github.com/briantist/galactory/blob/2b3be897f541181f71209434a20086a2114d0e5f/tests/unit/conftest.py#L86-L93

Although I got the tests to "pass", it turns out that it's not working properly.

I haven't been able to completely figure out why yet, but it seems like is_dir() is always returning True and that means in our tests we end up testing nothing https://github.com/briantist/galactory/blob/2b3be897f541181f71209434a20086a2114d0e5f/tests/unit/conftest.py#L103

Galactory still works fine with Python 3.10 and 3.11 and I expect that will continue, but means there's even less testing than I thought 😞

I've still not made enough headway on #21 , I really need to step up testing in this project.