university and school names

brianvoe / gofakeit

Random fake data generator written in go

MIT License

4.56k stars 264 forks source link

university and school names #265

Closed wulfharth7 closed 1 year ago

wulfharth7 commented 1 year ago

I've created a basic generator for the issue #255, I think it has room to improve, but I'll take a look later when I have time. I tried to code it in an hour because I was excited lol.

brianvoe commented 1 year ago

This is a really good pr. The only thing i ask is instead of "schoolGen" you can just call it "school".

If you cant get to it ill make the change otherwise Ill wait till you make the change and get it merged in.

Nice job!

brianvoe commented 1 year ago

Also dont forget to add it to the readme so others can find it.

wulfharth7 commented 1 year ago

@brianvoe

yes sure, in an hour I'll do it and update it. thanks for your comment :)

also do you think the project is a bit messy? i think it can be improved, are you open for pr like that?

i may add more data btw while I'm updating it. fyi.

brianvoe commented 1 year ago

Im not looking for any big changes right now.

As far as data well take it one pr at a time

wulfharth7 commented 1 year ago

Im not looking for any big changes right now.

As far as data well take it one pr at a time

First time contributing in an open-source project so I was excited, I'm still a student, I've added some data, updated the readme and added customized function.

Enjoy :D

Edit: I also just realized that I forgot to change the comment in the test file, so it says SchoolGen still. Also forgot to add the lookup function to the lookup.go so when you merge, be aware of those changes. Didn't want to commit another fix because of commit history. Just small stuff.

brianvoe commented 1 year ago

Ok thanks. before i merge this in i have to figure why your pr looks like it's changing the whole file for the readme and lookup addition. Those two are like 3 line changes and github sees it as a full file changes. are you formatting it and changing it somehow?

brianvoe commented 1 year ago

Example of someone making a simple change and it not showing the whole file changing.

brianvoe commented 1 year ago

I cant merge this in until we figure this out. What IDE are you using? If anything revert back, open it in a simple text editor make your one line changes and repush.

wulfharth7 commented 1 year ago

I think LF line endings has turned into CRLF somehow, im fixing it now and pushing again soon.

brianvoe commented 1 year ago

ok sounds good. thanks for doing that