addeed the possibility to set an aria label

brianvoe / slim-select

Slim advanced select dropdown

http://slimselectjs.com

MIT License

1.03k stars 195 forks source link

addeed the possibility to set an aria label #497

Closed andreanironi closed 9 months ago

andreanironi commented 9 months ago

First attempt to address #496 . The documentation update is still to be added.

Is it ok to use aria-label? I saw a comment mentioning the possibility to add support to aria-labelledby. What would be the behavior in this case? Pass a selector as a setting?
Is the "Combobox" default ok?

Let me know your thoughts!

brianvoe commented 9 months ago

I dont see an issue with this. My only thought is do we allow them to set something or do we just set aria labels for them.

Let me know your thoughts.

Thanks for the pr.

hamedbaatour commented 1 month ago

@brianvoe This PR addresses the accessibility issue partially. However, it seems that the ss-content element is still missing an aria-label. Additionally, the ariaLabel property does not appear to be documented anywhere.