search

brianvoe / slim-select

Slim advanced select dropdown
http://slimselectjs.com
MIT License
1.03k stars 195 forks source link

Text Highlighter Update #545

Closed Tonksthebear closed 4 months ago

Tonksthebear commented 4 months ago

Hello! I noticed a regression when finally getting around to updating to v2. Essentially, it's a repeat of this issue

I haven't worked with typescript projects before so I'm sorry if my PR doesn't contain all of the necessary updates in order for this to be merged (I'm not sure if there is a build step that compiles the typescript to javascript, or if I have to do that myself). But, in my testing, it just required a simple regex change in order to ensure only text inside of html elements are matched, and not their respective attributes.

Happy to clean this up in whichever way it needs to

brianvoe commented 4 months ago

Seems simple enough. Ill get it merged in.