brianvoe / slim-select

Slim advanced select dropdown
http://slimselectjs.com
MIT License
1.07k stars 200 forks source link

Allow key presses not relevant to SlimSelect to propagate to default handlers #550

Closed meagar closed 5 months ago

meagar commented 5 months ago

While the main div has focus, it soaks up all onkeydown events. Those it recognizes (arrow keys, tab, space, enter, etc) are dispatched to its event handlers, but all unrecognized key events are dropped and prevented from propagating.

This means, while the select box has focus:

Instead, all these standard keyboard shortcuts have no effect until the main div is unfocused, which is pretty confusing and annoying behavior. Accessibility issues aside, as a user, if the last thing I did was select an option from a slim-select, my "reload page" keyboard shortcut appears broken for no obvious reason.

This small change from return false to return true lets keyboard events bubble up to their default browser handlers.

Note: I'm on OSX and have tried Firefox and Chrome with identical results. Other browsers or operating systems may do a better job at disallowing in-page event handlers from blocking fundamental features like "Reload".


Just noticed this fixes #526 I misinterpreted that issue, this PR does not fix it.

brianvoe commented 5 months ago

Thanks for the pr but this issue is resolved in an upcoming update.