brianwyka / brackets-clientlibs-combine

Brackets plugin which combines clientlib files
https://registry.brackets.io/
MIT License
3 stars 1 forks source link

Not working on my Brackets 1.6 ? #3

Closed Daminoweb closed 8 years ago

Daminoweb commented 8 years ago

Hello and thanks for the plugin. I was using concat Brackets CSS concat and Brackets JS concat, but was looking for just one plugin to combine CSS and JS files. That's why I install your plugin. Unfortunately the plugin doesn't work on my 1.6 Brackets. Is there any things I haven't understood ?

I create a clientlibs.combile file in my root directory and fill it with :

{
    "combineOnSave": false,
    "combine": [
        {
            "output": "combine/css/styles.min.css",
            "files": [
                "style1.css",
                "style2.css"
            ]
        },
        {
            "output": "combine/js/perso.min.js",
            "files": [
                "jstest/*.js"
            ]
        },
    ]
}

But when I right-click on the file and click Combine client Libs, nothing happens.

Thanks for your help.

wykapedia commented 8 years ago

I have tested on Brackets 1.6 and it is working for me. Do you see any errors in the console?

Daminoweb commented 8 years ago

Hi and thanks for your answer. I'm not a good dev enough to explore errors but ... The only error I have when I launch Combine Client Libs is : Uncaught SyntaxError: Unexpected token ]

Daminoweb commented 8 years ago

Hi again I've disable some extensions and it's OK. I'm triyng to find the one responsable for that error.

Daminoweb commented 8 years ago

Last test. No problem of extensions, it was just a problem of coma. Here is the code OK

{
    "combineOnSave": false,
    "combine": [
        {
            "output": "combine/css/styles.min.css",
            "files": [
                "style1.css",
                "style2.css"
            ]
        },
        {
            "output": "combine/js/perso.min.js",
            "files": [
                "jstest/*.js"
            ]
        }
    ]
}
wykapedia commented 8 years ago

Good find.