brianzinn / react-babylonjs

React for Babylon 3D engine
https://brianzinn.github.io/react-babylonjs/
812 stars 102 forks source link

React-18 #226

Closed dennemark closed 2 years ago

dennemark commented 2 years ago

Mounting of engine needs testing - not sure if changing from react 17 to 18 is considered properly by react-reconciler.

Unmounting of Html component works differently, hopefully no bugs.

brianzinn commented 2 years ago

Thanks @dennemark - really appreciate your help on this - I have been really swamped lately! I will run some tests and update downstream projects as well. I need to revisit the whole code generation thing anyway, because it's not going to work now that Babylon team is doing so many releases. The codegen isn't backwards compatible, so I'll need to move to more dynamic rendering - will be a challenge to do that and support tree shaking. Probably the codegen should just be used for generating the typings and JSX Intrinsic elements...

I'll update also the launch config for code gen that is useful for debugging, much nicer to use ts-node/esm...