search

brianzinn / react-babylonjs

React for Babylon 3D engine
https://brianzinn.github.io/react-babylonjs/
812 stars 102 forks source link

Breaking changes between 3.1.11 and 3.1.13 #251

Closed coder89 closed 1 year ago

coder89 commented 1 year ago

Hi,

Today I was doing a packages upgrade and discovered that 3.1.13 introduces a breaking change that isn't documented (or at least I couldn't find any info about it). All props like position-x, scale-y, etc. stopped working. Turns out that this library no longer takes care of these. Was this intentional design change (that should be documented somewhere in the release notes) or should it be treated as a bug?

Properties without -x -y -z work just fine BTW.

Thanks!

brianzinn commented 1 year ago

It was intentional. I wasn’t sure about the community impact, because it wasn’t really documented. The arcRotateCamera crashes if you change the upVector, because it has a set accessor. What I was trying to do was guide people down the right path. If you look at TransformNode the position is a serAccessor that sets an internal property. I think I’m ok to put it back - to be honest I was very surprised how many properties used set accessors.

what do you think?

brianzinn commented 1 year ago

closing as "by design", since it follows best practices automatically.