search

brianzinn / react-babylonjs

React for Babylon 3D engine
https://brianzinn.github.io/react-babylonjs/
809 stars 102 forks source link

Can't resolve '@babylonjs/core/Engines/Extensions/engine.views.js' #321

Closed scriptex closed 1 month ago

scriptex commented 1 month ago

Recent updates to the core library (@babylonjs/core) started triggering this error.

I am trying to update the core library to v7.9.0 (or any version above v7.8.0 FWIW) and it keeps throwing this error.

After checking in the available files in node_modules I see that the mentioned file exists in version v7.8.0 but is no longer available in future versions.

brianzinn commented 1 month ago

thank-you for reporting. i will check the downstream and perhaps make a PR there or release here. this doesn't happen very often due to their backwards compatibility

scriptex commented 1 month ago

Thank you! I checked the latest core library releases and their changelogs and couldn't find anything related to this change. It might not be a breaking change for the core lib but unfortunately it triggers issues in libs built on top...

brianzinn commented 1 month ago

thanks @scriptex - I will be doing a PR to core library for them to maintain backwards compatibility. I should PR today hopefully and then it will drop in next release.

brianzinn commented 1 month ago

https://github.com/BabylonJS/Babylon.js/pull/15154

coolbeatz71 commented 1 month ago

The issue is still persisting. Should we wait for another release so the change can take effect?

scriptex commented 1 month ago

They merged the linked PR so I guess it will be released soon.

brianzinn commented 1 month ago

@coolbeatz71 - can’t do much except wait. The new core lib will be backwards compatible. I don’t know if there is an official release schedule. I will drop a new release after with some new features, so I’m waiting as well. Cheers.

scriptex commented 1 month ago

They've released v7.10.0 which fixes this issue 🎉 ! Thanks for the quick turnaround, I am closing the issue 😄