search

brianzq / att-bill-splitter

Command-line tool for splitting AT&T phone bills among lines (Family Plan, Share Value Plan, etc.).
https://brianzq.me/projects/1
MIT License
51 stars 14 forks source link

skip promo popup when logging in #11

Closed matthewwo closed 7 years ago

matthewwo commented 7 years ago

Added a get request which effectively skips the promotion page.

I couldn't seem to make login work by opening a browser and logging in before using this splitter. Instead I've tweaked the login process such that it will skip the promotion page for the user automatically.

matthewwo commented 7 years ago

Thanks for making this project possible!!! Made my life much easier should have found this years ago when I started splitting my ATT plan haha.

Will do the formatting once I get home. Btw, I’m not familiar with the python setup script, how would you compile and test?

brianzq commented 7 years ago

I'm glad you find this useful. I'm curious how you find about it? And currently there is no test. If there are more people contributing to this, I might add some tests and set up continuous integration some day.

matthewwo commented 7 years ago

I always wanted to write a script similar to this one but procrastinated :/

Then I decided to lookup if there's any luck on GitHub and I found you made this project!! Really appreciate your effort.

brianzq commented 7 years ago

LGTM. I'll merge it in and upload to pypi.