PR for exposing the 'set' functionality of ProgressBarJS

[robert-j-webb]

Hi, would you be interested in a PR that makes it so you can call the 'set' function on the progress bar before the animate function? Here's the code I wrote for it:

didRender(...args) {
    this._super(...args);

    const { progressBar, progress, setProgress } = getProperties(
      this,
      'progressBar',
      'progress',
      'setProgress'
    );

    if (isPresent(setProgress)) {
      progressBar.set(setProgress);
    }

    progressBar.animate(progress, () => this.sendAction('onAnimationComplete'));
  },

I'd write a test for it!

[briarsweetbriar]

Sure!

On Thu, Mar 15, 2018, 4:25 PM Robert Webb notifications@github.com wrote:

Hi, would you be interested in a PR that makes it so you can call the 'set' function on the progress bar before the animate function? Here's the code I wrote for it:

didRender(...args) { this._super(...args);

const { progressBar, progress, setProgress } = getProperties(
  this,
  'progressBar',
  'progress',
  'setProgress'
);

if (isPresent(setProgress)) {
  progressBar.set(setProgress);
}

progressBar.animate(progress, () => this.sendAction('onAnimationComplete'));

},

I'd write a test for it!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/patience-tema-baron/ember-progress-bar/issues/7, or mute the thread https://github.com/notifications/unsubscribe-auth/ACk2SJz9UbRwjeA4gx-T2O_PFsBgKEb0ks5tes5RgaJpZM4Ss1E8 .

[briarsweetbriar]

Thanks for the PR! Just released this under 1.0.0.