search

briatte / ggnetwork

Geoms to plot networks with ggplot2
https://briatte.github.io/ggnetwork/
146 stars 28 forks source link

Updated imports to include ggplot2::Stat to address issue #14 #15

Closed trinker closed 7 years ago

trinker commented 7 years ago

Hope this is helpful...

Added the import of ggplot2::Stat as discussed in issue #14. Appears to have done the trick. Package version needs bumped. Build still has unrelated warnings/notes in tests. Specifically:

* checking Rd \usage sections ... WARNING
Undocumented arguments in documentation object 'geom_edgetext_repel'
  'segment.color'

Undocumented arguments in documentation object 'geom_nodetext_repel'
  'segment.color'

Functions with \usage entries need to have the appropriate \alias
entries, and all their arguments documented.
The \usage entries must correspond to syntactically valid R code.
See chapter 'Writing R documentation files' in the 'Writing R
Extensions' manual.

and in tests:

* checking tests ...
  Running 'testthat.R' ERROR
Running the tests in 'tests/testthat.R' failed.
Last 13 lines of output:
   Type help(package="sna") to get started.

  1. Failure: load_pkg works (@test-utilities.R#5) -------------------------------
  error$message does not match "install the".
  Actual value: "could not find function "load_pkg""

  testthat results ================================================================
  OK: 14 SKIPPED: 0 FAILED: 1
  1. Failure: load_pkg works (@test-utilities.R#5) 

  Error: testthat unit tests failed
  Execution halted
briatte commented 7 years ago

Tons of thanks for that! I'll repair the rest in the coming days when I get back home.