search

briatte / ggnetwork

Geoms to plot networks with ggplot2
https://briatte.github.io/ggnetwork/
146 stars 28 forks source link

House keeping to pass Travis #26

Closed koheiw closed 5 years ago

koheiw commented 6 years ago

Version number should be incremented to reflect the fix and to be consistent with NEWS.

koheiw commented 6 years ago

I did a few housekeeping works for you to make CI work. I believe that other PR will also pass Travis once you merge this.

briatte commented 5 years ago

Dear @koheiw

First of all, all apologies for not answering this PR earlier.

Many thanks for your suggestions: I have reflected most of them in the current build, and they helped a lot with Travis CI indeed! I'll be adding you to the "thank you" notes of the README and NEWS files.

Also, your newsmap package (discovered via your blog) looks awesome, will certainly use it (I have large amounts of tweets and need to find those in French)!

koheiw commented 5 years ago

@briatte Great to see ggplotnetwork to be updated. newsmap has French dictionary by Claude Grasland, who is not really on Github, but please check for typo. PR is always welcome.

briatte commented 5 years ago

Will do!