fix #49 with a unified approach/function

briatte / ggnetwork

Geoms to plot networks with ggplot2

https://briatte.github.io/ggnetwork/

146 stars 28 forks source link

fix #49 with a unified approach/function #56

Closed mcanouil closed 5 years ago

mcanouil commented 5 years ago

I created a new internal function format_fortify to homogenise the two fortify which were basically doing the exact same thing but relying on two different packages. Amongs other things, this fix the issue #49 and will make things easier to maintain the fortify function (only one place to look for any modification)

briatte commented 5 years ago

I believe this will also simplify tests a bit.

I have only one hesitation about the cbind/sapply method, given issue #59.

briatte commented 5 years ago

Alright, let's merge and see what happens (AppVeyor is failing for some reason that I don't understand, but Travis CI seems fine)!

mcanouil commented 5 years ago

Appveyor is apparently failing because it cannot access some ressources it needs to initialise/install the windows virtual machine.

It should works again later.

briatte commented 5 years ago

Thanks a lot again. I'm in the train so not the best place to code, but I'll reorganise a few things and then edit the NEWS to make this the big change in my (weird) version history.