chore(deps): update dependency gradle to v8.10.1

renovate[bot] commented 1 month ago

This PR contains the following updates:

Package	Update	Change
gradle (source)	patch	`8.10` -> `8.10.1`

Release Notes

gradle/gradle (gradle)

### [`v8.10.1`](https://redirect.github.com/gradle/gradle/compare/v8.10.0...v8.10.1) [Compare Source](https://redirect.github.com/gradle/gradle/compare/v8.10.0...v8.10.1)

Configuration

📅 Schedule: Branch creation - "before 9am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

wiiitek commented 1 month ago

I have similar issues when trying to upgrade Gradle in some other project:

Build project with an old version of Gradle: ./gradlew clean build
Upgrade Gradle: ./gradlew wrapper --gradle-version 8.10.1
Try to build project again: ./gradlew clean build

expected:

New Gradle version should build the project.

actual:

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':server:compileKotlin'.
> Could not create task ':server:checkKotlinGradlePluginConfigurationErrors'.
   > DefaultTaskCollection#configureEach(Action) on task set cannot be executed in the current context.

However it works ok if I build with: ./gradlew --no-daemon clean build.

So maybe the issue here is that we cache Gradle state between jobs with gradle/gradle-build-action@v3?

We probably still want to use this action for faster builds, however documentation says:

When you switch to a new Gradle wrapper version or upgrade a dependency version the old files are not automatically and immediately removed

~~We could change the config for cache cleanup behaviour~~. I think the default value makes sense and is safe.

My proposition:

let's try to manually delete the cache in GitHub and try re-run the workflow.

@bric3, could you try it when you have some time?

bric3 commented 1 month ago

@wiiitek Thank you for chiming in. Unfortunately removing caches doesn't seem to help there. It seems the --no-daemon has more potential. But this seems to be a workaround.

I am not in hurry to upgrade Gradle, so I'll wait for a new version that these issues.

renovate[bot] commented 1 month ago

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (8.10.1). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

bric3 / excalidraw-jetbrains-plugin