bricas / geo-ipfree

Look up the country of an IPv4 address
http://metacpan.org/release/Geo-IPfree
5 stars 4 forks source link

Unused dependencies on Test2:: modules #8

Open ppisar opened 2 years ago

ppisar commented 2 years ago

There is a regression in 1.160000 version:

Makefile.PL reads:

  "TEST_REQUIRES" => {
    "ExtUtils::MakeMaker" => 0,
    "File::Spec" => 0,
    "File::Temp" => 0,
    "Test2::Bundle::Extended" => 0,
    "Test2::Plugin::NoWarnings" => 0,
    "Test2::Tools::Explain" => 0,
    "Test::More" => 0
  },

But there is no use of File::Temp, Test2::Bundle::Extended, Test2::Plugin::NoWarnings, and Test2::Tools::Explain modules in the ./t directory. They are only tested for an available version by t/00-report-prereqs.t:

$ grep -Hnr Test2:: t t/00-report-prereqs.dd:34: 'Test2::Bundle::Extended' => '0', t/00-report-prereqs.dd:35: 'Test2::Plugin::NoWarnings' => '0', t/00-report-prereqs.dd:36: 'Test2::Tools::Explain' => '0', t/00-report-prereqs.dd:45: 'Test2::Bundle::Extended' => '0', t/00-report-prereqs.dd:46: 'Test2::Plugin::NoWarnings' => '0', t/00-report-prereqs.dd:47: 'Test2::Tools::Explain' => '0',

I recommend removing those dependencies.