search

bricaud / graphexp

Interactive visualization of the Gremlin graph database with D3.js
Apache License 2.0
784 stars 216 forks source link

3.4 compatibility #60

Closed justinhauer closed 5 years ago

justinhauer commented 5 years ago

Has this been tested with gremlin server 3.4?

teereence commented 5 years ago

Hi The key / value detaisls of nodes don't show, when a node is clicked on. Though I am not fully sure it is related to 3.4, I was thinking this was due to a change in return format of g.valueMap.

Any thoughts about that?

(using latest tinker pop version with neo4j backend, same issue with Janus backend)

andrewhallambc commented 5 years ago

We have also noticed this when connecting to tinker pop. Neptune does show the node keys though so it looks like it is related to the underlying graph DB connecting too?

It does not seem to be related to 3.4 as we are finding this issue with 3.3.2

BTW, we love this tool, keep up the good work folks.

bricaud commented 5 years ago

You are right @teereence , it comes from a change in valueMap(). It does not return any more the node properties. I am working on it. I have to modify the command in gremlin_query_nodes, inside the function click_query() within graphioGremlin.js. And maybe a few other steps processing the data. Thanks everyone for the feedback.

smurfzilla commented 5 years ago

Love this tool as well - am seeing the same issue with 3.4.1 - is there a milestone or projected ETA for resolution of this?

nallbradley commented 5 years ago

Any updates on this? Me and my team love the tool and are relying on it for graph exploration. Can we help with this? Don't want to jump on it though if @bricaud is already working it.

bricaud commented 5 years ago

I would be very happy to get some help on it. I can't find time at the moment to modify the code. Sorry. The gremlin query must be changed (one solution is to use valuemap() at the end of the query) and the properties returned are not in the same format.

bricaud commented 5 years ago

I also think I need to focus on vertex properties and forget the idea of displaying properties of vertex properties. This seems to require a gemlin query for each property of property.

bricaud commented 5 years ago

I have created a branch for graphexp adapted to Gremlin 3.4 (branch g_3.4). The new query get the vertex properties for 3.4 but uses options that are not compatible with 3.3 (.with(WithOptions.tokens)) . so it does not work with 3.3 and earlier versions. It correctly displays vertex properties when you click on a vertex. You need to click on it twice though because the first time the properties are not there (I did not update yet the search_query() function that get the data in the beginning). PR on this branch are welcome!

bricaud commented 5 years ago

Compatibility with gremlin 3.4 on branch g_34 has been updated. It looks good now. Could you test and report if you find bugs? If it is fine, I will merge it to the master in a week.

mkilp commented 5 years ago

Can we merge this into master now?

bricaud commented 5 years ago

Merged